Skip to content
This repository has been archived by the owner on Apr 25, 2019. It is now read-only.

Embed Containers http #76

Closed
gazjoy opened this issue Sep 6, 2016 · 2 comments
Closed

Embed Containers http #76

gazjoy opened this issue Sep 6, 2016 · 2 comments
Assignees
@gazjoy
Labels
bug
Milestone
September 2016

Comments

@gazjoy
Copy link
Collaborator

gazjoy commented Sep 6, 2016

https://getchopchop.github.io/html/utility/index.html#section-embed-container

Embed containers need protocol relative url to stop content being blocked on the demo site.
@gazjoy gazjoy added this to the September 2016 milestone Sep 6, 2016
@gazjoy gazjoy self-assigned this Sep 6, 2016
@daveredfern daveredfern added the bug label Sep 6, 2016
@daveredfern
Copy link
Member

The urls are pointing to // so must be something else. Maybe the publish process?

@gazjoy gazjoy modified the milestones: September 2016, October 2016 Sep 22, 2016
gazjoy pushed a commit that referenced this issue Sep 22, 2016
#76 hard link to https on youtube embeds to fix published site video.
1acdbce
@gazjoy
Copy link
Collaborator Author

gazjoy commented Sep 22, 2016

@daveredfern I have hard linked them to https, this should sort the problem. 1acdbce

Needs a cursory check once next release is published.

@gazjoy gazjoy closed this as completed Sep 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gazjoy gazjoy

Labels
bug
Projects
None yet
Milestone
September 2016
Development

No branches or pull requests
2 participants
@daveredfern @gazjoy