improving logging in GetLobbyInstancesWithPingData test, bailing out …

…early if pingRegions fails
getbraincloud · Feb 7, 2024 · 37501da · 37501da
1 parent 43e9860
commit 37501da
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/tests/src/TestBCLobby.cpp b/tests/src/TestBCLobby.cpp
@@ -373,10 +373,16 @@ TEST_F(TestBCLobby, GetLobbyInstancesWithPingData)
     // Fetch pings
     m_bc->getLobbyService()->getRegionsForLobbies({ "MATCH_UNRANKED" }, & tr);
     tr.run(m_bc);
-	
+
     m_bc->getLobbyService()->pingRegions(&tr);
     tr.run(m_bc);
 
+    if(!tr.m_result){
+        // ping error
+        GTEST_FATAL_FAILURE_("test failure with pingRegions - bailing out before completion\n");
+        return;
+    }
+
     m_bc->getLobbyService()->getLobbyInstancesWithPingData("MATCH_UNRANKED", "{\"rating\":{\"min\":1,\"max\":1000},\"ping\":{\"max\":100}}", &tr);
     tr.run(m_bc);
 }
diff --git a/tests/src/TestResult.cpp b/tests/src/TestResult.cpp
@@ -83,12 +83,12 @@ bool TestResult::runExpectCount(BrainCloudClient * in_bc, int in_apiCountExpecte
     if (!m_done)
     {
         // we timed out so try to reset the comms and throw the error
-        if (!in_noAssert) EXPECT_TRUE(m_done);
         in_bc->resetCommunication();
         m_result = false;
         m_statusCode = 999;
         m_reasonCode = 999;
         m_statusMessage = "TEST TIMEOUT EXCEEDED";
+        if (!in_noAssert) EXPECT_TRUE(m_done);
     }
     else
     {