fix: Don't block with readFileSync in remote recording finish

[zermelo-wisen]

Fixes #70

[dividedmind]

Please make sure errors are reported instead of being silently swallowed. Easiest way to do this is probably to spin out an async function instead of using the callback flavor of readFile. (Node will show an error message when an exception is thrown in a promise but not caught, which is good enough IMO.)

[zermelo-wisen]

Actually my first attempt was to make the Proxy trap for emit asynchronous and use fs.promisses version of readFile instead. But I "felt" it won't be correct even if I wasn't able to find an evidence.

[dividedmind]

Actually my first attempt was to make the Proxy trap for emit asynchronous and use fs.promisses version of readFile instead. But I "felt" it won't be correct even if I wasn't able to find an evidence.

Not sure what you mean with proxy trap, but here's roughly what I have in mind:

        if (recording.finish()) {
          res.writeHead(200);
          const { path } = recording;
          void (async () => {
            res.end(await readFile(path));
            await rm(path);
            reset();
          })();
        } else {
          res.writeHead(200).end("{}");
          reset();
        }

[appland-release]

🎉 This PR is included in version 2.23.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀