fix: Check if recordings are still active after promise resolution

getappmap · Apr 25, 2024 · a72a1e7 · a72a1e7
1 parent 5a6afae
commit a72a1e7
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/src/recorder.ts b/src/recorder.ts
@@ -76,7 +76,11 @@ export function fixReturnEventsIfPromiseResult(
       (value) => {
         const elapsed = getTime() - startTime;
         const promiseClass = `Promise<${getClass(value)}>`;
+        const currentActiveRecordings = getActiveRecordings();
         recordings.map((recording, idx) => {
+          // If the recording is not active after promise resolution
+          // don't attempt to record an eventUpdate.
+          if (!currentActiveRecordings.includes(recording)) return;
           const newReturn = makeReturnEvent(
             returnEvents[idx].id,
             callEvents[idx].id,
@@ -90,7 +94,11 @@ export function fixReturnEventsIfPromiseResult(
       },
       (reason) => {
         const elapsed = getTime() - startTime;
+        const currentActiveRecordings = getActiveRecordings();
         recordings.map((recording, idx) => {
+          // If the recording is not active after promise resolution
+          // don't attempt to record an eventUpdate.
+          if (!currentActiveRecordings.includes(recording)) return;
           const event = makeExceptionEvent(
             returnEvents[idx].id,
             callEvents[idx].id,