Refactor terraform to support 0.12, and bump k8s to v1.14.6 #33
Conversation
smalltown
commented
Sep 5, 2019
•
smalltown
commented
- All: support terraform 0.12 (Update scripts to support terraform v0.12.x #32)
- All: Kubernetes upgrade to 1.14.6
- ElastiKube: Etcd upgrade to v3.4.0, CoreDNS upgrade to 1.6.2 , flannel upgrade to 0.11.0
|
Just created a cluster with that PR, runs great. Thanks! |
|
Wow ! @pragmaticivan thank for your feedback very much, |
|
Done of the development, but not complete yet, need to
|
There was a problem hiding this comment.
Looks almost good to me. However I think there are lots of things that can be polished.
E.g., Most maps we used as input variables can be replaced by object, to make them more descriptive and more understandable.
We can do such refactoring in upcoming releases.
modules/ignitions/etcd/certs.tf
Outdated
| gid = 232 | ||
| mode = 256 | ||
| uid = var.etcd_user_id | ||
| gid = var.etcd_user_id |
There was a problem hiding this comment.
Would be better if there is a new var var.etcd_group_id or we can use an object like
{
uid = 232
gid = 232
}There was a problem hiding this comment.
sure, let me add it in next commit
|
|
||
| content { | ||
| content = "${coalesce(var.content, join("", data.template_file.kubeconfig.*.rendered))}" | ||
| content = coalesce(var.content, join("", data.template_file.kubeconfig.*.rendered)) |
There was a problem hiding this comment.
let me check it, thank for reviewing
There was a problem hiding this comment.
if disable user to pass their own kubeconfig content, then this join can be disabled
| ] | ||
| } | ||
|
|
||
| output "content" { | ||
| value = "${coalesce(var.content, join("", data.template_file.kubeconfig.*.rendered))}" | ||
| value = coalesce(var.content, join("", data.template_file.kubeconfig.*.rendered)) |
kairen
added
do-not-merge/work-in-progress
kairen
removed
the
do-not-merge/work-in-progress
kairen
changed the title
