fix: add check for status and replied at #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiwiidb
approved these changes
Jun 23, 2023
bumi
requested changes
Jun 26, 2023
| "replyEventId": resp.ID, | ||
| "appId": nostrEvent.AppId, | ||
| }).Info("Published reply") | ||
| } |
There was a problem hiding this comment.
what should we do in the else case? what other state can status be? and I think we should log/save that one, too.
otherwise we do not know if/when/why this happens.
There was a problem hiding this comment.
Made changes, please review again
bumi
reviewed
Jun 26, 2023
| "replyEventId": resp.ID, | ||
| "appId": nostrEvent.AppId, | ||
| }).Info("Failed to publish reply") | ||
| } else { |
There was a problem hiding this comment.
do you know what other status it can have? and when this could happen?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94