This repository was archived by the owner on Sep 2, 2024. It is now read-only.
chore: show topup/increase option ony if available #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The backends without channel management do not have support for this
* master: Update README.md
rolznz
reviewed
Jun 30, 2024
| <Button variant="outline">Increase</Button> | ||
| </Link> | ||
| </CardFooter> | ||
| {hasChannelManagement && ( |
There was a problem hiding this comment.
Thanks, I didn't think about this 😱
But we should hide the entire card, right? "Receiving capacity" makes no sense for LNClients without channel management
I don't think the design is finalized yet, so it might be best to wait for that
We could do this, but there should be no way to access those pages normally (as long as we don't forget to implement these checks 😅 ) |
if the backend does not have any channel management then the incoming capcity box does not make sense
rolznz
reviewed
Jul 1, 2024
| <Button variant="outline">Increase</Button> | ||
| </Link> | ||
| </CardFooter> | ||
| {hasChannelManagement && ( |
There was a problem hiding this comment.
I think this one still needs to be updated to hide the whole card
reneaaron
pushed a commit
that referenced
this pull request
Jul 4, 2024
Co-authored-by: Roland Bewick <roland.bewick@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backends without channel management do not have support for this.