Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show confirm exit dialog before closing desktop app #935

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

pavanjoshi914
Copy link
Contributor

Fixes #825

image

@pavanjoshi914 pavanjoshi914 requested a review from rolznz January 3, 2025 10:22
Copy link
Contributor

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@rolznz rolznz requested a review from im-adithya January 6, 2025 13:11
@rolznz rolznz merged commit 36349b2 into master Jan 6, 2025
8 of 9 checks passed
@rolznz rolznz deleted the desktop-app-close-alert branch January 6, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn before closing the desktop app
2 participants