Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: nwc create_connection command (WIP) #907

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Dec 18, 2024

This is a bit of an exploration on how new app connections could be created via nwc (e.g. for NWA). e.g. in Alby Go.

Things I noticed:

  • initial implementation is quite minor, most of the code is already written.
  • use methods instead of scopes since scopes do not exist in the NIP-47 spec.
  • UI change required to have the new superuser scope
  • budgets and other restrictions do not make sense if this scope exists, since the superuser scope can create new connections without restrictions
  • Alby Go would need a custom detail page to enable the superuser scope
  • Does there need to be a way in the hub to explicitly confirm a superuser scope to create an app (e.g. re-entering unlock password?)
  • add missing tests
  • implement in JS SDK
  • implement "NWA" in bitcoin connect
  • implement "NWA" in Alby Go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant