-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fire channel open and closure events in lnd #849
Conversation
We also can add a ChannelActive update publisher in the same PR but I'm not sure if it's the same as ChannelReady in LDK. Is ChannelReady triggered when peer connection is lost (making the channel inactive) and then connected again? |
@im-adithya channel_ready in LDK is only triggered once, when the newly-opened channel is ready to be used |
@im-adithya it would be good to also add the channel_ready event in this PR. Is there something equivalent in LND? |
Ah then LND doesn't have any similar method, I'll see if there's any alternate way of doing this |
@im-adithya possibly we can subscribe to the |
Sorry my bad, there actually is an open channel event as well 🤦 added now! |
@im-adithya does that event run when the channel is opened or when it is opened AND the channel has the required confirmations? |
It only runs when the channel is ready to use (i.e when the min required block confirmations are done) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Fixes #806
Adds a channel event susbcription to listen to channel closures.
closureReason
can be the following:"COOPERATIVE_CLOSE"
"LOCAL_FORCE_CLOSE"
"BREACH_CLOSE"
"REMOTE_FORCE_CLOSE"
"FUNDING_CANCELED"
"ABANDONED"