feat: use nip44 and versioning #834
Conversation
im-adithya
requested review from
rolznz and
bumi
and removed request for
rolznz
|
spec PR needs to adapt to the notifications (legacy and new) nostr-protocol/nips#1531 |
|
@im-adithya it would be good to add some tests, especially for any changes in the |
|
Feedback is addressed, only have to agree on the Also have to add tests. |
|
@im-adithya if you also add some tests for isVersionSupported to ensure it passes the versions we support maybe it is ok for now and we don't need to simplify it (since you already wrote it) |
|
I wonder if it's good to add the NIP-47 version to the app table, and default to 0.0 for existing entries. We do not republish info events for apps on startup. Later we might want to show which connections EDIT: did not signal they support NIP-44 so that the user can remove them and re-add them? CC @reneaaron @frnandu @bumi |
|
|
||
| relay.PublishedEvent = nil | ||
| relay.PublishedEvents = nil |
There was a problem hiding this comment.
shouldn't this be an empty array?
There was a problem hiding this comment.
It is of type []*nostr.Event
| walletPrivKey, err := svc.keys.GetAppWalletKey(app.ID) | ||
| _, err = svc.GetNip47Service().PublishNip47Info(ctx, relay, *app.WalletPubkey, walletPrivKey, svc.lnClient) | ||
| if err != nil { | ||
| logger.Logger.WithError(err).WithFields(logrus.Fields{ |
There was a problem hiding this comment.
@frnandu it's ok if we just log an error and proceed here, right?
Fixes #737
Ready for review (use getAlby/js-sdk#273)
(so nip-44 doesn't work currently as the relays block 23917 kind)(Fixed by Fernando)Tests are to be added/modified(Done)