Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metadata field to make_invoice command #357

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Jul 27, 2024

This enables apps to easily attach metadata to invoices rather than requiring an external database. This can currently be done by encoding data in the description field which will be included in the invoice itself, but there are a few downsides:

  • it makes the invoice QR code harder to scan
  • user doesn't understand the encoded content which should actually be a description
  • description is limited to 639 bytes and then gets switched to a description hash, which can break apps

TODOs:

@rolznz rolznz marked this pull request as ready for review July 27, 2024 08:47
@rolznz rolznz added this to the v1.4.0 milestone Jul 31, 2024
@rolznz rolznz merged commit f464a5a into master Jul 31, 2024
8 checks passed
@rolznz rolznz deleted the feat/make-invoice-metadata branch July 31, 2024 15:12
@rolznz rolznz mentioned this pull request Jul 31, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant