feat: delete old ldk payments #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdmitr
reviewed
Feb 14, 2025
lnclient/ldk/ldk.go
Outdated
| for _, payment := range payments { | ||
| paymentCreatedAt := time.Unix(int64(payment.CreatedAt), 0) | ||
| if paymentCreatedAt.Add(maxInvoiceExpiry * time.Second).Before(now) { | ||
| logger.Logger.WithField("created_at", paymentCreatedAt).Debug("Deleting old payment") |
lnclient/ldk/ldk.go
Outdated
| @@ -50,6 +50,7 @@ type LDKService struct { | |||
| } | |||
|
|
|||
| const resetRouterKey = "ResetRouter" | |||
| const maxInvoiceExpiry = 86400 // 1 day | |||
There was a problem hiding this comment.
Nitpick: use time.Duration for readability and ergonomics? I.e. time.Hour * 24
…f deleted payments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1073
When we store a lot of payments in VSS it slows down startup a lot, because LDK must fetch all the data one key at a time to build the node. We do not need the old expired payments to be stored by LDK because we also store transactions stored in Alby Hub.
This does set the maximum of invoice expiry to 1 day to ensure we do not remove old payments that are not expired yet. I do not think any service needs longer invoice expiry than one day though?