feat: replace start timeout with hub startup state #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
im-adithya
reviewed
Feb 14, 2025
| @@ -129,6 +94,11 @@ export default function Start() { | |||
| <LoadingButton type="submit" loading={loading}> | |||
There was a problem hiding this comment.
Should we then also change the title of the TwoColumnLayoutHeader to Start as well?
im-adithya
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1073
Originally we added an arbitrary timeout and delayed messages to give the user the feeling that something is happening.
The problem with the timeout is even after the timeout we cannot do anything because we lock the startup and it's impossible to try again until the startup definitely succeeds or fails.
I have replaced the timeout with showing the actual current state of the node startup. (Only on the start screen - the finish screen for first node startup is fast enough)