fix: check for invoice expiry before navigating to send

getAlby · Dec 16, 2024 · 821ba28 · 821ba28
1 parent 4c5db75
commit 821ba28
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/frontend/src/screens/wallet/Send.tsx b/frontend/src/screens/wallet/Send.tsx
@@ -42,6 +42,7 @@ export default function Send() {
       }
 
       const invoice = new Invoice({ pr: recipient });
+
       navigate(`/wallet/send/confirm-payment`, {
         state: {
           args: { paymentRequest: invoice },

diff --git a/transactions/transactions_service.go b/transactions/transactions_service.go
@@ -206,6 +206,14 @@ func (svc *transactionsService) SendPaymentSync(ctx context.Context, payReq stri
 		return nil, err
 	}
 
+	if time.Now().After(time.Unix(int64(paymentRequest.CreatedAt+paymentRequest.Expiry), 0)) {
+		logger.Logger.WithFields(logrus.Fields{
+			"bolt11": payReq,
+		}).Errorf("Failed to decode bolt11 invoice: %v", err)
+
+		return nil, errors.New("this invoice has expired")
+	}
+
 	selfPayment := paymentRequest.Payee != "" && paymentRequest.Payee == lnClient.GetPubkey()
 
 	var dbTransaction db.Transaction