Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add alby hub #267

Merged
merged 14 commits into from
Feb 21, 2025
Merged

feat: add alby hub #267

merged 14 commits into from
Feb 21, 2025

Conversation

rolznz
Copy link
Collaborator

@rolznz rolznz commented Jan 18, 2025 •
edited
Loading

  • Adds Alby Hub option
  • Uses new fromAuthorizationUrl method in Alby JS SDK
  • Removes old connectors (Mutiny, Alby Account)
  • Should Umbrel be kept? no (use Alby Hub instead).

TODOs:

  • update to new version of JS SDK (locally linked to this JS SDK version, so this PR will not compile)
  • Update design of Alby Hub page
  • Hide Alby Go for now (Wait for NWA support)

image
image
image

@socket-security Socket Security
Copy link

socket-security bot commented Feb 19, 2025 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@rolznz rolznz changed the title feat: add alby hub (WIP) feat: add alby hub Feb 19, 2025
@rolznz rolznz marked this pull request as ready for review February 19, 2025 10:20
@rolznz rolznz mentioned this pull request Feb 19, 2025
Closed
reneaaron
reneaaron approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, great progress! 💯

tACK

@rolznz
Copy link
Collaborator Author

rolznz commented Feb 20, 2025

@reneaaron we just need a new icon for the "Don't have a bitcoin wallet?" page before we can merge this, right?

@reneaaron
Copy link
Contributor

Yeah, exactly. If you want to merge now we can maybe also just go with no icon for now, as we'll postpone the release anyway?

@socket-security Socket Security
Copy link

Report too large to display inline

View full report↗︎

@rolznz rolznz merged commit 4b2d0e3 into master Feb 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reneaaron reneaaron reneaaron approved these changes

@im-adithya im-adithya Awaiting requested review from im-adithya

@stackingsaunter stackingsaunter Awaiting requested review from stackingsaunter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rolznz @reneaaron