Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/result processor #186

Merged
merged 5 commits into from
Apr 24, 2024
Merged

Feat/result processor #186

merged 5 commits into from
Apr 24, 2024

Conversation

credmond-git
Copy link
Collaborator

feat: change Metrics to Observability.

  • convert the validation into a result processor that takes in the results of getting a config then returns a processed results.
  • to be more consistent rename the PostProcessor to be the ConfigNodeProcessor. Then move it into the processor package.
  • convert the validation to a result processor that has its own list of ConfigValidators. If the validation is not enabled, do not add the ValidationResultProcessor.

…e results of getting a config then returns a processed results.

feat: to be more consistent rename the PostProcessor to be the ConfigNodeProcessor. Then move it into the processor package.
…ist of ConfigValidators. If the validation is not enabled, do not add the ValidationResultProcessor.
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 96.89119% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 90.64%. Comparing base (5336d95) to head (b121f68).

❗ Current head b121f68 differs from pull request most recent head f16135f. Consider uploading reports for the commit f16135f to get more accurate results

Files Patch % Lines
.../github/gestalt/config/builder/GestaltBuilder.java 95.77% 1 Missing and 2 partials ⚠️
...in/java/org/github/gestalt/config/GestaltCore.java 90.90% 0 Missing and 1 partial ⚠️
...nfig/processor/result/ResultsProcessorManager.java 94.73% 0 Missing and 1 partial ⚠️
...va/org/github/gestalt/config/utils/ErrorsUtil.java 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
+ Coverage   90.35%   90.64%   +0.29%     
==========================================
  Files         215      219       +4     
  Lines        6086     6148      +62     
  Branches      706      704       -2     
==========================================
+ Hits         5499     5573      +74     
+ Misses        366      357       -9     
+ Partials      221      218       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@credmond-git credmond-git force-pushed the feat/result-processor branch 4 times, most recently from 7736d02 to 7cbc656 Compare April 24, 2024 05:19
@credmond-git credmond-git force-pushed the feat/result-processor branch from 7cbc656 to b121f68 Compare April 24, 2024 05:21
Copy link

Quality Gate Passed Quality Gate passed

Issues
12 New issues
2 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.4% Duplication on New Code

See analysis details on SonarCloud

@credmond-git credmond-git merged commit c7c17fc into main Apr 24, 2024
3 checks passed
@credmond-git credmond-git deleted the feat/result-processor branch April 24, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant