Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/metrics #177

Merged
merged 10 commits into from
Apr 4, 2024
Merged

Feat/metrics #177

merged 10 commits into from
Apr 4, 2024

Conversation

credmond-git
Copy link
Collaborator

feat: add a metric manager that hooks into gestalt and allows to submit metrics to a metrics recorder. #171
Provide a implementation for micrometer.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 90.59561% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 89.79%. Comparing base (ff270d9) to head (fbcab0f).

❗ Current head fbcab0f differs from pull request most recent head 57552b7. Consider uploading reports for the commit 57552b7 to get more accurate results

Files Patch % Lines
...in/java/org/github/gestalt/config/GestaltCore.java 78.16% 9 Missing and 10 partials ⚠️
.../main/java/org/github/gestalt/config/tag/Tags.java 75.00% 1 Missing and 3 partials ⚠️
...n/java/org/github/gestalt/config/GestaltCache.java 66.66% 0 Missing and 3 partials ⚠️
.../github/gestalt/config/builder/GestaltBuilder.java 95.12% 1 Missing and 1 partial ⚠️
.../github/gestalt/config/metrics/MetricsManager.java 92.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #177      +/-   ##
============================================
+ Coverage     89.14%   89.79%   +0.64%     
- Complexity        0       47      +47     
============================================
  Files           185      192       +7     
  Lines          5419     5666     +247     
  Branches        649      673      +24     
============================================
+ Hits           4831     5088     +257     
+ Misses          387      365      -22     
- Partials        201      213      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@credmond-git credmond-git merged commit 5da5c05 into main Apr 4, 2024
3 checks passed
@credmond-git credmond-git deleted the feat/metrics branch April 4, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant