Implement session nanos #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implements quick session index lookups via session nanos. - Amends quick minute index lookup to a similar common implementation. Adds following properties and methods: - `all_sessions_nanos` - `_get_session_idx` - `_get_date_idx` - `_get_minute_idx` - `_get_sessions_slice` - `_get_minutes_slice` - `_date_oob` - `_minute_oob` Also: - restricts date input to `is_session` and `date_to_session` to dates within calendar range. - changes default `raise_oob` option of parsing methods from False to True.
maread99
force-pushed
the
session-nanos-0
branch
from
7251dc5 to
30d7891
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Side effect of implementation is to allow a considerable number of parsing calls to be handled by common
_get_*_idxmethods.Also, restricts date input to
is_sessionanddate_to_sessionto dates within calendar range. This removes the current ambiguity of whether False is saying the date is 'not a session' or 'is out of calendar range, but it might be a session'.Added following properties and methods:
all_sessions_nanos_get_session_idx_get_date_idx_get_minute_idx_get_sessions_slice_get_minutes_slice_date_oob_minute_oob