Improve test: Add '[]' suffix to multi-select name attr #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 18, 2024
Closed
germsvel
pushed a commit
that referenced
this pull request
Jul 5, 2024
Fixes #77 Replaces #79, #90, #93 ## Goal Ensure same form handling semantics as Phoenix controllers and LiveView. ## Details Track form data as a flat list of `{name, value}` tuples instead of nested maps. This can be read straight from the DOM and needs no further conversions. Example: ```ex form_data = [ {"user[name]", "Ada"}, {"user[subscribe][]", "email"}, {"user[subscribe][]", "push"} ] ``` Defer transforming that flat list into a nested data structure: When submitting form or evaluating other LiveLive `phx-*` callbacks. Use [Plug.Conn.Query.decode/4](https://github.com/elixir-plug/plug/blob/v1.16.0/lib/plug/conn/query.ex#L9) to transform flat list into nested data structure. Reason: Phoenix Controllers and LiveView do the same (see #77 (comment)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #74
Align
PageViewwithIndexLive:<select multiple>should use nameattrending in[].Even though the tests do not currently fail (decode multiple values), an actual Phoenix app would fail (decode only a single value).
As a follow-up, it might be good to make the
Staticdriver stricter to emulate real-world behaviour.https://github.com/elixir-plug/plug/blob/v1.16.0/lib/plug/parsers/urlencoded.ex
https://github.com/elixir-plug/plug/blob/v1.16.0/lib/plug/conn/query.ex#L24