Refactor: Move assertions into 'Driver' protocol #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftes
force-pushed
the
refactor/move-assertions-to-driver-protocol
branch
from
d512153 to
1a52c98
Compare
Closed
|
Thanks @ftes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #74
Goal
Allow more flexibility for Driver implementations.
Background
Browser-based testing is inherently decoupled, and usually involves some retry/await concept to ensure the rendered web UI is up to date with the server side state.
Wrapping the assertion functions in the
Driverprotocol allows flexibility for browser-based Drivers:PhoenixTest.Assertions