Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update URLs to point to correct place #6

Closed
mkevenaar opened this issue Sep 2, 2019 · 7 comments
Closed

Update URLs to point to correct place #6

mkevenaar opened this issue Sep 2, 2019 · 7 comments
Labels
improvement
Milestone
0.2.0

Comments

@mkevenaar
Copy link
Contributor

No description provided.

@mkevenaar mkevenaar added this to the 0.1.1 milestone Sep 2, 2019
@mkevenaar mkevenaar assigned mkevenaar and unassigned mkevenaar Sep 2, 2019
@mkevenaar
Copy link
Contributor Author

The current release notes point to https://raw.githubusercontent.com/gep13/PoshBot.Soon/develop/CHANGELOG.md and it does not exist.

@gep13
Copy link
Member

gep13 commented Sep 3, 2019

@mkevenaar I am not a fan of duplicating information if we can avoid it. In this case, I think we should change the URL to be:

https://github.com/gep13-oss/PoshBot.Soon/releases

Thoughts?

@mkevenaar
Copy link
Contributor Author

Yip I agree. I was just following what was already there

@gep13 gep13 changed the title Add CHANGELOG.md file Update release notes URL to point to correct place Sep 3, 2019
@AdmiringWorm
Copy link

@gep13 @mkevenaar if you can, maybe point the release notes url directly to the exact release that was built?

@mkevenaar
Copy link
Contributor Author

@AdmiringWorm That would mean that we need to change the ReleaseNotes URL on every release. I think pointing to the releases page is perfectly acceptable.

@mkevenaar mkevenaar changed the title Update release notes URL to point to correct place Update URLs to point to correct place Sep 3, 2019
@mkevenaar
Copy link
Contributor Author

Besides ReleaseNotes URL also the following URLs have been fixed:

  • ProjectUri
  • LicenseUri

mkevenaar added a commit that referenced this issue Sep 3, 2019
@mkevenaar
(GH-6) Update URLs to point to correct place
d4a9a05
@mkevenaar
Copy link
Contributor Author

This is implemented here: d4a9a05

gep13 added a commit that referenced this issue Sep 3, 2019
@gep13
Merge branch 'release/0.2.0'
b5f0b56 
* release/0.2.0:
  (GH-8) Add more soon images
  (GH-6) Update URLs to point to correct place
  (GH-7) Add Maurice to Owners section in PSD1 file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
3 participants
@mkevenaar @gep13 @AdmiringWorm