Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9625: fix not showing layer name in identify dropdown for imported vector layers #9626

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

mahmoudadel54
Copy link
Contributor

Description

Fix issue of not showing layer name of imported vector layers in identify dropdown layer list.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

#9625

What is the current behavior?
#9625

What is the new behavior?
Now if user makes an import for a vector layer on the map then clicks on any of its feature on the map ---> identify part will open and the dropdown list of layer names will containing the name of this layer like:

image

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Copy link
Contributor

@MV88 MV88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MV88 MV88 merged commit c27b0a5 into geosolutions-it:master Oct 19, 2023
@MV88
Copy link
Contributor

MV88 commented Oct 19, 2023

@ElenaGallo Please test it in DEV

@tdipisa
Copy link
Member

tdipisa commented Oct 20, 2023

@ElenaGallo please test and let us know if we can backport. Thank you.

@ElenaGallo
Copy link
Contributor

Test passed, @mahmoudadel54 please backport to 2023.02.xx. Thanks

@ElenaGallo ElenaGallo added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Oct 20, 2023
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this pull request Oct 20, 2023
@mahmoudadel54
Copy link
Contributor Author

Test passed, @mahmoudadel54 please backport to 2023.02.xx. Thanks

Backport is done >> #9636

MV88 pushed a commit that referenced this pull request Oct 24, 2023
@MV88 MV88 removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layer name no longer visualized in Identify drop down for imported vector layers
4 participants