-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uniformation of Edit Properties and detail card #5834
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Great! We cleaned up a lot. I'd like to clean up even more. I think we can reuse almost everything from the ResourceGrid. Please look at my inline comments for details
-
I see there is an undo button when you create a new detail card that should not appear. Probably is due to the NODATA handling I mentioned
-
If I remove from the FeatureGrid the detail card, I still see the detail button. Clicking on it causes shows a "NODATA"
-
Please add unit tests for new things you wrote.
web/client/components/resources/modals/fragments/DetailsRow.jsx
Outdated
Show resolved
Hide resolved
web/client/components/resources/modals/fragments/DetailsSheet.jsx
Outdated
Show resolved
Hide resolved
@offtherailz when should the undo button appear |
@vlt1 checking the current behaviour, only when the user deleted the detail card, to restore it. In fact I see the text is "undo remove" |
@offtherailz if rework is good I'll add tests |
@vlt1 looks really great! 👍 🚀 |
Description
Replaces MetadataModal with existing general SaveModal in MapGrid. Adds details sheet to that SaveModal. Also should solve this behaviour.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#5772
What is the current behavior?
#5772
What is the new behavior?
MetadataModal in MapGrid is removed and replaced with SaveModal. SaveModal is extended with details sheet.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)