Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more fixes for the plugins example: themes and config editing #2585

Merged
merged 1 commit into from
Feb 2, 2018

Conversation

mbarto
Copy link
Contributor

@mbarto mbarto commented Feb 2, 2018

Description

Plugins example still needs some fixes to the config editing

Issues

  • Fixes plugins example config editing

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Config help not working

What is the new behavior?
Config help working

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.686% when pulling 77ac473 on mbarto:more_plugins_example_fixes into 8e9f08d on geosolutions-it:master.

@mbarto mbarto merged commit 1b8e1ed into geosolutions-it:master Feb 2, 2018
@offtherailz offtherailz mentioned this pull request Mar 7, 2018
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants