Fixed #2219 zoom to page #2419
Merged
Fixed #2219 zoom to page #2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
offtherailz
reviewed
Nov 22, 2017
| @@ -16,7 +16,7 @@ const getSaveMessageId = ({saving, saved}) => { | |||
| return "featuregrid.toolbar.saveChanges"; | |||
| }; | |||
|
|
|||
| module.exports = ({events = {}, mode = "VIEW", selectedCount, hasChanges, hasGeometry, hasNewFeatures, isSimpleGeom, isDrawing = false, isEditingAllowed, saving = false, saved = false, isDownloadOpen, isColumnsOpen, disableToolbar, isSearchAllowed, disableDownload, displayDownload, isSyncActive = false, hasSupportedGeometry = true} = {}) => | |||
| module.exports = ({events = {}, mode = "VIEW", selectedCount, hasChanges, hasGeometry, hasNewFeatures, isSimpleGeom, isDrawing = false, isEditingAllowed, saving = false, saved = false, isDownloadOpen, isColumnsOpen, disableToolbar, isSearchAllowed, disableDownload, displayDownload, isSyncActive = false, hasSupportedGeometry = true, allFeaturesWithNoGeometry = false} = {}) => | |||
There was a problem hiding this comment.
maybe we could rename this parameter disableZoomTo
There was a problem hiding this comment.
i'll go for disableZoomAll because its id is "zoom-all"
offtherailz
approved these changes
Nov 23, 2017
This was referenced Dec 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Zoom to page fails if a feature in the pages has no geometry
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
actually it does not soozm because it fails internally to create the bbox
What is the new behavior?
now it does not fails and it zooms to the page
Does this PR introduce a breaking change? (check one with "x", remove the other)