Fix #1873 Wrong Font Family and Size on Print plugin #1874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbarto
suggested changes
May 23, 2017
web/client/plugins/print/index.js
Outdated
| @@ -119,6 +119,7 @@ const Font = connect((state) => ({ | |||
| italic: state.print && state.print.spec && state.print.spec.italic | |||
| }), { | |||
| onChangeFamily: setPrintParameter.bind(null, 'fontFamily'), | |||
| onChangeName: setPrintParameter.bind(null, 'fontName'), | |||
There was a problem hiding this comment.
fontName is not used, I think. You still use only fontFamily in PrintUtils. Maybe we don't need a duplicated property at all
tdipisa
approved these changes
May 24, 2017
mbarto
pushed a commit
that referenced
this pull request
May 29, 2017
* Fixed LocalUtils and Setting plugin to display supported locales (#1864) * Improved thumbnail customization of Background Selector (#1870) * Fixes #1867: print example not loading due to misaligned pdfjs version (#1871) * Fixes #1868: fixed some of the plugins to better work in the plugins … (#1875) * Fixes #1868: fixed some of the plugins to better work in the plugins example * Removed duplicate plugin * Fix #1873 Wrong Font Family and Size on Print plugin (#1874) * Fixed font family and size on print * Fixed font name in legend options * Moved background selector (#1876) * Fixed background selector issue on mobile search (#1879) * Fixes #1866: queryform example updated with epics and other related f… (#1877) * Fixes #1866: queryform example updated with epics and other related fixes * Removed unnecessary check * Fix #1880 search fails on ie (#1881)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.