Fix #1612. Extent calculation for GeoJson supported #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbarto
suggested changes
Mar 21, 2017
web/client/utils/CoordinatesUtils.js
Outdated
| extent[2] = (ext[2] > newExtent[2]) ? ext[2] : newExtent[2]; | ||
| extent[3] = (ext[3] > newExtent[3]) ? ext[3] : newExtent[3]; | ||
| return [ | ||
| (ext[0] < extent[0]) ? ext[0] : extent[0], |
There was a problem hiding this comment.
can we create a function with this stuff, that is repeated many times?
There was a problem hiding this comment.
Sure, as you see the original one had many side effects. I didn't noticed they become exactly the same function after my refactor.
mbarto
approved these changes
Mar 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now GeoJson extent calculation support also
FeatureandFeatureCollection(before this only geometry was supported).