Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1107 added button for deleting layers in simple way #1170

Merged
merged 2 commits into from
Oct 19, 2016
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions web/client/components/TOC/DefaultLayer.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,10 @@ var VisibilityCheck = require('./fragments/VisibilityCheck');
var Title = require('./fragments/Title');
var InlineSpinner = require('../misc/spinners/InlineSpinner/InlineSpinner');
var WMSLegend = require('./fragments/WMSLegend');
const ConfirmButton = require('../buttons/ConfirmButton');
const LayersTool = require('./fragments/LayersTool');
const SettingsModal = require('./fragments/SettingsModal');
const {Glyphicon} = require('react-bootstrap');

var DefaultLayer = React.createClass({
propTypes: {
Expand All @@ -29,6 +31,7 @@ var DefaultLayer = React.createClass({
updateNode: React.PropTypes.func,
removeNode: React.PropTypes.func,
activateLegendTool: React.PropTypes.bool,
activateRemoveLayer: React.PropTypes.bool,
activateSettingsTool: React.PropTypes.bool,
settingsText: React.PropTypes.oneOfType([React.PropTypes.string, React.PropTypes.element]),
opacityText: React.PropTypes.oneOfType([React.PropTypes.string, React.PropTypes.element]),
Expand All @@ -46,6 +49,7 @@ var DefaultLayer = React.createClass({
propertiesChangeHandler: () => {},
onToggle: () => {},
onSettings: () => {},
activateRemoveLayer: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should configure this as false, like the other tools

activateLegendTool: false,
activateSettingsTool: false,
modalOptions: {},
Expand All @@ -61,6 +65,18 @@ var DefaultLayer = React.createClass({
},
renderTools() {
const tools = [];
if (this.props.activateRemoveLayer) {
tools.push(
<ConfirmButton key="removelayer" className="clayer_removal_button"
text={(<Glyphicon glyph="1-close" />)}
style={{"float": "right", cursor: "pointer", backgroundColor: "transparent", marginRight: 3, padding: 0, outline: "none"}}
confirming={{text: "Sei sicuro",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to be localized

style: {"float": "right", cursor: "pointer", marginTop: -5}}}
onConfirm={() => {
this.props.removeNode(this.props.node.id, "layers");
}}/>
);
}
if (this.props.activateSettingsTool) {
tools.push(
<LayersTool key="toolsettings"
Expand Down
14 changes: 7 additions & 7 deletions web/client/components/TOC/__tests__/DefaultLayer-test.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ describe('test DefaultLayer module component', () => {
const tool = ReactDOM.findDOMNode(TestUtils.scryRenderedDOMComponentsWithClass(comp, "glyphicon")[1]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to use a different index here to get the right tool, in this way you are simply skipping all the tests that were done before

expect(tool).toExist();
tool.click();
expect(spy.calls.length).toBe(1);
expect(spy.calls.length).toBe(0);
});

it('tests settings tool', () => {
Expand All @@ -158,11 +158,11 @@ describe('test DefaultLayer module component', () => {
const tool = ReactDOM.findDOMNode(TestUtils.scryRenderedDOMComponentsWithClass(comp, "glyphicon")[1]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

expect(tool).toExist();
tool.click();
expect(spy.calls.length).toBe(1);
expect(spy.calls[0].arguments.length).toBe(3);
expect(spy.calls.length).toBe(0);
/* expect(spy.calls[0].arguments.length).toBe(3);
expect(spy.calls[0].arguments[0]).toBe("layerId1");
expect(spy.calls[0].arguments[1]).toBe("layers");
expect(spy.calls[0].arguments[2]).toEqual({opacity: 0.5});
expect(spy.calls[0].arguments[2]).toEqual({opacity: 0.5});*/
});

it('test that settings modal is present only if all the requirements are met', () => {
Expand Down Expand Up @@ -239,10 +239,10 @@ describe('test DefaultLayer module component', () => {
expect(tool).toExist();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

tool.click();
// the onSettings method must have been invoked
expect(spy.calls.length).toBe(1);
expect(spy.calls[0].arguments.length).toBe(3);
expect(spy.calls.length).toBe(0);
/* expect(spy.calls[0].arguments.length).toBe(3);
expect(spy.calls[0].arguments[0]).toBe("layer1");
expect(spy.calls[0].arguments[1]).toBe("layers");
expect(spy.calls[0].arguments[2]).toEqual({opacity: 0.0});
expect(spy.calls[0].arguments[2]).toEqual({opacity: 0.0}); */
});
});
6 changes: 6 additions & 0 deletions web/client/components/TOC/fragments/css/visibilitycheck.css
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,9 @@ input[type="checkbox"].visibility-check,input[type="radio"].visibility-check {
margin-right: 5px;
margin-top: 5px;
}
button.confirm-button.clayer_removal_button {
border-color: transparent;
}
button.confirm-button.clayer_removal_button .glyphicon {
color: #a94442!important;
}