Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10719: enable upload images within Text widgets #10735

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mahmoudadel54
Copy link
Contributor

Description

This PR handles enabling upload image in Text Editor within Text Widgets by adding 'prop' called 'enableUploadImg' passing it to 'CompactRichTextEditor' component

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

#10719

What is the current behavior?
#10719
Text Widgets don't include upload image within image button, it is just adding image by providing URL.

What is the new behavior?
Now Text Widgets include upload image beside image URL within adding image feature.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

Description:
- add 'prop' called 'enableUploadImg' passing it to 'CompactRichTextEditor' component to enable upload image
- add unit test
@mahmoudadel54 mahmoudadel54 added this to the 2025.01.00 milestone Jan 7, 2025
@mahmoudadel54 mahmoudadel54 requested a review from MV88 January 7, 2025 09:47
@mahmoudadel54 mahmoudadel54 self-assigned this Jan 7, 2025
@mahmoudadel54 mahmoudadel54 linked an issue Jan 7, 2025 that may be closed by this pull request
6 tasks
@mahmoudadel54 mahmoudadel54 marked this pull request as ready for review January 7, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload images on Text widgets
1 participant