Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10631 New MapStore Home Page #10731

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

allyoucanmap
Copy link
Contributor

@allyoucanmap allyoucanmap commented Dec 19, 2024

Description

This PR introduces changes on the plugins related to homepage and resources workflow.
Due to extensive changes the new plugins and related components has been included in a subfolder inside the plugins directory called ResourcesCatalog, here few reason about this structure:

  • in development phase used to ensure there was not dependencies with current homepage component
  • in general to isolate new components and facilitate the deletion of old one

It would be better if we formalize a way to structure related plugins and shared components, anyway this structure could be changed during the review or later on (eg. when deprecated components will be removed) to align it to the expected structure.

The plugins included and refactored are:

  • BrandNavbar: replacement for the OmniBar, this menu will be used in all pages as main menu. OmniBar will be used just for map viewers
  • DeleteResource: includes the delete workflow for all the resource category and it will replace all the specific ones
  • EditContext: adds buttons to the resource card for contexts
  • Footer: refactor of the product Footer plugin, it removes the image and it rely on the html translation for everything
  • HomeDescription: refactor of the product HomeDescription plugin
  • ResourceDetails: replacement for the resource editing dialog. It will be used both in view and edit mode
  • ResourcesFilterForm: a filter form panel available in the home for resources grid
  • ResourcesGrid: a resources grid/list view. This plugin replaces all the specific grids with a single one
  • Save: includes the save workflow for all the resource category and it will replace all the specific ones
  • SaveAs: includes the save as workflow for all the resource category and it will replace all the specific ones

Homepage with BrandNavbar, HomeDescription and ResourcesGrid used for featured and all resources and
image

ResourceDetails in view mode
image

ResourcesFilterForm with ResourcesGrid with list layout
image

BrandNavbar and ResourceDetails inside the map viewer
image

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Feature

Issue

What is the current behavior?

#10631

What is the new behavior?

Refactored homepage and workflows related to resources.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@allyoucanmap allyoucanmap self-assigned this Jan 7, 2025
@allyoucanmap allyoucanmap linked an issue Jan 7, 2025 that may be closed by this pull request
8 tasks
@allyoucanmap allyoucanmap added New Feature used for new functionalities Homepage labels Jan 7, 2025
@allyoucanmap allyoucanmap added this to the 2025.01.00 milestone Jan 7, 2025
@allyoucanmap allyoucanmap marked this pull request as ready for review January 8, 2025 12:05
@tdipisa tdipisa requested a review from offtherailz January 8, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Homepage New Feature used for new functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New MapStore Home Page
1 participant