Dark theme toggle #10721
Dark theme toggle #10721
Conversation
Added a use effect that reloads the Theme prop and rebuilds the css include
Added button with styling to toggle between dark theme mode and light theme mode. Controls the theme prop inside of theme.jsx
There was a problem hiding this comment.
@weuceda14 Thank you so much for your contribution.
We are already evaluating the introduction of this in issue #10670. That implementation should be analyzed on the light of the new MS Home page work we are following as there are relevant considerations to do due to core changes we are applying there that are of course involving the theme part.
As a general contributing rule I suggest you to check what reported in the MS community bylaws by ensuring there is an issue for all PRs to be raised and also I suggest you to stay in touch with us and the community through the mailing list or the issue itself before proposing changes. this just to ensure to follow the right path for proposed changes. Thank you anyway for using MS and to be available to contribute to it.
Description
Added a button that allows the user to switch between dark mode and light mode.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
Dark theme files are present in the codebase but don't have the option to toggle between them both
What is the new behavior?
New button that when clicked changes the themeing of the project.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information