fix: Set column label in feature grid through customizeAttribute #10638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
This PR allow developer to change column label in featureGrid.
But, with the new 'title' column, this feature is broken.
So, move label from
nametotitle.Breaking change
This feature is originally to change the label of columns. If a developer used it to change the 'name', which is no longer used today for the columns label, the 'name' is no longer modified by the
labelbut keeps its original value. It is thetitlewhich now takes the value of thelabel.Other useful information
I can keep the original override
namevaleur by the label, but it doesn't make sense anymore.