Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maps widget dropdown menu is not visible on embedded dashboard #9110

Closed
1 task done
ElenaGallo opened this issue Apr 19, 2023 · 3 comments · Fixed by #9114
Closed
1 task done

Maps widget dropdown menu is not visible on embedded dashboard #9110

ElenaGallo opened this issue Apr 19, 2023 · 3 comments · Fixed by #9114

Comments

@ElenaGallo
Copy link
Contributor

ElenaGallo commented Apr 19, 2023

Description

On QA only, the maps widget dropdown menu is not visible on embedded dashboard.

3.mov

How to reproduce

Expected Result
On DEV (it is the correct one)

ok

Current Result

On prod: the dropdown menu is cut off
prod

On QA: the dropdown menu is under the map
qa

  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information

@ElenaGallo ElenaGallo added the bug label Apr 19, 2023
@ElenaGallo ElenaGallo added this to the 2023.01.01 milestone Apr 19, 2023
@tdipisa tdipisa removed their assignment Apr 19, 2023
@dsuren1
Copy link
Contributor

dsuren1 commented Apr 19, 2023

@tdipisa

On prod: the dropdown menu is cut off

The styling from cadastrapp extension is forcing the .Select-menu-outer to set width: 160.
Screenshot 2023-04-19 at 5 01 02 PM

Fix:

  • We can modify on the cadastrapp extension's css as the usage of this style override is not advisable.

  • Or we can do it on the MS, however we usually don't enforce !important unless overriding a style of a lib or some class that should always take precedence. Maybe adding only to map-switcher's child alone is okay

.mapstore-widget-header .map-switcher .Select-menu-outer {
  ....,
  width: 100% !important
}

On QA: the dropdown menu is under the map

The map widget is using leaflet as default maptype in dashboard embedded and a style leaflet-pane is setting z-index: 400 causing the overlap
image

Fix to 2023.01.01
Adding maptype reducer to appConfigDashboardEmbedded will set default maptype from localConfig.json

(as should be fixed in next stable when #8334 is promoted)

@tdipisa
Copy link
Member

tdipisa commented Apr 19, 2023

@dsuren1

We can modify on the cadastrapp extension's css or do it on the MS

I've removed the cadastrapp extension from the PROD instance but the issue is still there.

Adding maptype reducer to appConfigDashboardEmbedded will set default maptype from localConfig.json

Ok. Since you mentioned #8334, please consider also further changes included through #9012 that may be relevant.

@dsuren1
Copy link
Contributor

dsuren1 commented Apr 19, 2023

@dsuren1

We can modify on the cadastrapp extension's css or do it on the MS

I've removed the cadastrapp extension from the PROD instance but the issue is still there.

It is now fixed in PROD. WRT to width of the select dropdown

image

Yes, it was probably a browser cache issue on my side.

However, the overlapping of map over dropdown in embedded view needs the fix reported in point 2 for both qa and prod.

Yes, it was clear as I've also commented above. Please concentrate your effort only on this ignoring point 1 for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants