Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase precision of Query Panel Circle/BBox Details #2668

Closed
4 tasks
offtherailz opened this issue Mar 1, 2018 · 0 comments · Fixed by #2720
Closed
4 tasks

Increase precision of Query Panel Circle/BBox Details #2668

offtherailz opened this issue Mar 1, 2018 · 0 comments · Fixed by #2720

Comments

@offtherailz
Copy link
Member

offtherailz commented Mar 1, 2018

Description

Query Panel Geometry details has a decimal precision fixed to 2 digits. It is not enough. User can not edit precise circle filter or bbox filters at high zoom levels.

  • When coordinates are in 4326 (useMapProjection === false in GeometryDetails)
    when you change the radius of a circle the center of the circle moves to the nearest point with coordinates multiple of 0.01.
  • When you click on input arrows, the step of 1 degree is too big. It should be smaller (may depend from the current map resolution, but a simple solution can be to setting the step of 0.01).
  • Because of live update of the geometry, if the user deletes a digit and insert another one, the geometry may jump here and there. We may introduce a debounce time (1 sec) for geometry update.

In case of Bug (otherwise remove this paragraph)

Browser Affected
any

Steps to reproduce

  • Open the map

  • Add a vector layer to the map

  • Search for "Colosseo" and select the first result

  • Open feature grid, then filter

  • Select circle filter and draw a circle on the map centered in the coliseum center
    image

  • Click on pencil to open filter's geometry details

  • change radius value

Expected Result

  • The circle only changes radius

Current Result

  • The circle moves it's center to the nearest point with coordinates multiple of 0.01
    Something like this:
    image

Other useful information (optional):

This is due to a wrong approximation + to fast live editing + wrong step.
We should:

  • increase precision in case of 4326.
  • debounce user input to update with 1s of delay.
  • Increase step for the input component at least to 0.01
  • Specify the unit of measure of the circle radius (m)
@tdipisa tdipisa added this to the 2018.02.00 milestone Mar 1, 2018
@tdipisa tdipisa added the ready label Mar 6, 2018
@kappu72 kappu72 added in progress and removed ready labels Mar 8, 2018
kappu72 pushed a commit to kappu72/MapStore2 that referenced this issue Mar 9, 2018
kappu72 pushed a commit to kappu72/MapStore2 that referenced this issue Mar 12, 2018
@kappu72 kappu72 mentioned this issue Mar 12, 2018
12 tasks
kappu72 added a commit to kappu72/MapStore2 that referenced this issue Mar 12, 2018
@chiaracurcio chiaracurcio self-assigned this Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants