Fixes #1764: allows overriding actions in plugins (#1765)

geosolutions-it · Apr 26, 2017 · c7dc556 · c7dc556
1 parent d7c559a
commit c7dc556
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 5 deletions.
diff --git a/web/client/components/plugins/PluginsContainer.jsx b/web/client/components/plugins/PluginsContainer.jsx
@@ -39,6 +39,9 @@ const PluginsContainer = React.createClass({
         monitoredState: React.PropTypes.object,
         defaultMode: React.PropTypes.string
     },
+    contextTypes: {
+        store: React.PropTypes.object
+    },
     getDefaultProps() {
         return {
             mode: 'desktop',
@@ -65,7 +68,7 @@ const PluginsContainer = React.createClass({
         this.loadPlugins(newProps.pluginsState);
     },
     getState(path) {
-        return get(this.props.monitoredState, path) || get(this.props.params, path);
+        return get(this.props.monitoredState, path) || get(this.props.params, path) || this.context[path];
     },
     getPluginDescriptor(plugin) {
         return PluginsUtils.getPluginDescriptor(this.getState, this.props.plugins,

diff --git a/web/client/components/security/UserMenu.jsx b/web/client/components/security/UserMenu.jsx
@@ -95,7 +95,7 @@ const UserMenu = React.createClass({
           if (itemArray.length > 0) {
               itemArray.push(<MenuItem key="divider" divider />);
           }
-          itemArray.push(<MenuItem key="logout" onClick={this.props.onLogout}><Glyphicon glyph="log-out" /> <Message msgId="user.logout"/></MenuItem>);
+          itemArray.push(<MenuItem key="logout" onClick={() => this.props.onLogout()}><Glyphicon glyph="log-out" /> <Message msgId="user.logout"/></MenuItem>);
       }
       return (
       <DropDown id="loginButton" className={this.props.className} pullRight bsStyle="success" title={this.renderButtonText()} {...this.props.menuProps} >

diff --git a/web/client/plugins/containers/ToolsContainer.jsx b/web/client/plugins/containers/ToolsContainer.jsx
@@ -135,7 +135,7 @@ const ToolsContainer = React.createClass({
             const toolCfg = this.getToolConfig(tool);
 
             return this.addTooltip(
-                <Tool {...toolCfg} tooltip={tooltip} btnSize={this.props.toolSize} bsStyle={this.props.toolStyle} help={help} key={tool.name || ("tool" + i)} mapType={this.props.mapType}
+                <Tool {...toolCfg} pluginCfg={tool.cfg} tooltip={tooltip} btnSize={this.props.toolSize} bsStyle={this.props.toolStyle} help={help} key={tool.name || ("tool" + i)} mapType={this.props.mapType}
                     {...tool.cfg} items={tool.items || []}>
                     {(tool.cfg && tool.cfg.glyph) ? <Glyphicon glyph={tool.cfg.glyph}/> : tool.icon}{help} {tool.text}
                 </Tool>,

diff --git a/web/client/plugins/login/index.js b/web/client/plugins/login/index.js
@@ -6,7 +6,7 @@
 * LICENSE file in the root directory of this source tree.
 */
 const React = require('react');
-const {connect} = require('react-redux');
+const {connect} = require('../../utils/PluginsUtils');
 const {geoStoreLoginSubmit, loginFail, logoutWithReload, geoStoreChangePassword, resetError} = require('../../actions/security');
 const {setControlProperty} = require('../../actions/controls');
 const {Glyphicon} = require('react-bootstrap');

diff --git a/web/client/utils/PluginsUtils.js b/web/client/utils/PluginsUtils.js
@@ -36,9 +36,12 @@ const isPluginConfigured = (pluginsConfig, plugin) => {
 
 /*eslint-disable */
 const parseExpression = (state = {}, context = {}, value) => {
-    const searchExpression = /^\{(.*?)\}$/;
+    const searchExpression = /^\{(.*)\}$/;
     const expression = searchExpression.exec(value);
     const request = url.parse(location.href, true);
+    const dispatch = (action) => {
+        return () => state("store").dispatch(action.apply(null, arguments));
+    };
     if (expression !== null) {
         return eval(expression[1]);
     }

diff --git a/web/client/utils/__tests__/PluginUtils-test.js b/web/client/utils/__tests__/PluginUtils-test.js
@@ -101,4 +101,12 @@ describe('PluginsUtils', () => {
     it('handleExpression', () => {
         expect(PluginsUtils.handleExpression({state1: "test1"}, {context1: "test2"}, "{state.state1 + ' ' + context.context1}")).toBe("test1 test2");
     });
+    it('dispatch', () => {
+        const expr = PluginsUtils.handleExpression(() => ({
+            dispatch: (action) => action
+        }), {context1: "test2"}, "{dispatch(() => 'test')}");
+
+        expect(expr).toExist();
+        expect(expr()).toBe("test");
+    });
 });