Added youtube videos and app stuff to seismic gpg. Improved survey section #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lheagy
reviewed
Oct 13, 2016
| @@ -29,7 +29,7 @@ | |||
| pWin=window.open(urlstring,winName, "toolbar=0,scrollbars=1,directories=0,resizable=1,height=" + height + ",width=" + width + ",status=0"); | |||
| } | |||
|
|
|||
| MM_preloadImages('./../../_images/firstbreak2.gif','./../../_images/firstbreak3.gif','./../../_images/firstbreak1.gif'); | |||
| MM_preloadImages('./images/firstbreak2.gif','./images/firstbreak3.gif','./images/firstbreak1.gif'); | |||
There was a problem hiding this comment.
This broke the radio button app. Could you please revert this change? @Pbellive
Have a look at the paths in _build/html for reference
There was a problem hiding this comment.
My understanding is that the figure using that radio button should be removed completely. That was my reasoning for leaving #112 open. This issue and that one can be closed when I update http://gpg.geosci.xyz/content/seismic/seismic_data.html
lheagy
reviewed
Oct 13, 2016
| @@ -38,13 +38,13 @@ | |||
| <tbody> | |||
| <tr> | |||
| <td valign="top" valign="top" style="width:30%;"> | |||
| <input name="radiobutton" type="radio" onClick="MM_swapImage('firstbreaks','','./../../../_images/firstbreak1.gif',1)" value="radiobutton" checked> | |||
| <input name="radiobutton" type="radio" onClick="MM_swapImage('firstbreaks','','./images/firstbreak1.gif',1)" value="radiobutton" checked> | |||
There was a problem hiding this comment.
again, these need to be reverted @Pbellive
lheagy
reviewed
Oct 13, 2016
|
|
||
| You can explore the concept further using an interactive web app `here <https://phet.colorado.edu/sims/html/wave-on-a-string/latest/wave-on-a-string_en.html>`__. | ||
|
|
||
| **Remark:** Large amplitudes of the transmitted wave are sometimes counter- |
There was a problem hiding this comment.
here, you can use a .. note:: environment to have this highlighted eg.
lheagy
reviewed
Oct 13, 2016
| .. raw:: html | ||
|
|
||
| <div style="margin-top:10px; margin-bottom:20px;" align="center"> | ||
| <iframe width="560" height="315" src="https://www.youtube.com/embed/FygYDmm99SA" frameborder="0" allowfullscreen></iframe> |
There was a problem hiding this comment.
can you please add the ?rel=0 to the end of the url here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ction.