Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script for scraping stats from GCClassic cloud benchmarks #335

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

yantosca
Copy link
Contributor

Name and Institution (Required)

Name: Bob Yantosca
Institution: Harvard + GCST

Describe the update

We have added a new script (gcpy/benchmark/modules/benchmark_gcclassic_stats.py) to scrape the statistics that are reported in the GEOS-Chem 1-month benchmark stats spreadsheet.

Expected changes

This will not change any existing plotting/tabling functionality. The script must be run manually, for example:

(gcpy_env)$ python -m gcpy.benchmark.modules.benchmark_gcclassic_stats 14.5.0-alpha.4 14.5.0-alpha.5

where 14.5.0-alpha.4 is the "Ref" version and 14.5.0-alpha.5 is the "Dev" version to compare. The output is printed in order of the columns in the spreadsheet:

 6:01:01  11.7216   13.67824118787    7.550699    4.480028  21661  2267  5021  1154  2020  29  1644  2402  2247  51  744  2418  1265

Reference(s)

N/A

Related Github Issue

N/A

gcpy/benchmark/modules/benchmark_gcclassic_stats.py
- Script to scrape statistics (Wall time, memory, OH metrics, timers)
  from the GEOS-Chem Classic cloud benchmarks on AWS

CHANGELOG.md
- Updated accordingly

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca yantosca added category: Feature Request New feature or request topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output labels Aug 22, 2024
@yantosca yantosca added this to the 1.5.1 milestone Aug 22, 2024
@yantosca yantosca self-assigned this Aug 22, 2024
gcpy/benchmark/modules/benchmark_gcclassic_stats.py
- Now print MCF (aka CH3CCl3) lifetime before CH4 lifetime, which is the
  proper order in the "GEOS-Chem 1-month benchmark stats" spreadsheet.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca
Copy link
Contributor Author

Note, we had the order of CH4 and MCF lifetimes swapped. The MCF lifetime should follow the mean OH concentration. Now fixed in 2c577f0.

(gcpy_env) $ python -m gcpy.benchmark.modules.benchmark_gcclassic_stats 14.5.0-alpha.4 14.5.0-alpha.5
 6:01:01  11.7216   13.67824118787    4.480028    7.550699  21661  2267  5021  1154  2020  29  1644  2402  2247  51  744  2418  1265  

gcpy/benchmark/modules/benchmark_gcclassic_stats.py
- Now write output in comma-separated format

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca
Copy link
Contributor Author

Now updated for comma-separated output. This can be added into a Google sheet with "split text to columns"

(gcpy_env) $ python -m gcpy.benchmark.modules.benchmark_gcclassic_stats 14.5.0-alpha.4 14.5.0-alpha.5
6:01:01,11.7216,13.67824118787,blank,4.480028,7.55069921661,2267,5021,1154,2020,29,1644,2402,2247,51,744,2418,1265,

Copy link
Contributor

@msulprizio msulprizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Bob! This looks great.

gcpy/benchmark/modules/benchmark_gcclassic_stats.py
- Add 2 blank columns after "Wall Time"
- Add 2 blank columns after "CH4"
- Remove "blank" after "Mean OH"

This now allows you to cut-n-paste the output into the Google sheet
and then pick Data -> Split cell into columns.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca yantosca merged commit a33bebf into dev Aug 27, 2024
@yantosca yantosca deleted the feature/cloud-benchmark-stats branch August 27, 2024 18:55
@yantosca yantosca modified the milestones: 1.5.1, 1.6.0 Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Feature Request New feature or request topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants