Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement From<&Line> for LineString #1020

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Conversation

gibbz00
Copy link
Contributor

@gibbz00 gibbz00 commented Jun 21, 2023

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

Manual implementation tends to be implemented inline (e.g https://github.com/frewsxcv/geo-bevy/blob/348085c43b58da8f321e04e77fa9bf7d624e60b4/src/lib.rs#L147) as From<Line> is possibly more restrictive than necessary. Not sure whether From<Line> uses copy over move even if it's an owned parameter.

Copy link
Member

@michaelkirk michaelkirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Not sure whether From uses copy over move even if it's an owned parameter.

My guess is that they are equivalent in this case. A move is a copy after all, but we expect the compiler to optimize it out in most cases.

This LGTM, but I'll leave it open for a couple days in case anyone else wants to weigh in.

@lnicola
Copy link
Member

lnicola commented Jun 22, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 22, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

  • ci result

@bors bors bot merged commit 9b477fc into georust:main Jun 22, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants