Drop pre-3.0 GDAL support #504
Conversation
lnicola
force-pushed
the
min-gdal-3-0
branch
from
5f375c9 to
f745033
Compare
| println!("cargo:rustc-cfg=major_ge_{major}"); | ||
| } | ||
|
|
||
| for minor in 0..=minor { | ||
| println!("cargo:rustc-cfg=minor_ge_{minor}"); | ||
| } | ||
|
|
There was a problem hiding this comment.
We never care about the patch version, so I think it's fine to emitting all those cfgs for it.
| @@ -14,28 +14,21 @@ fn main() { | |||
| let minor = (gdal_version - major * 1000000) / 10000; | |||
| let patch = (gdal_version - major * 1000000 - minor * 10000) / 100; | |||
There was a problem hiding this comment.
is that line calculating patch still needed ?
There was a problem hiding this comment.
It's still printed in the panic message below, just in case. Probably doesn't hurt to have it.
There was a problem hiding this comment.
ah ok, nevermind, I missed that use
lnicola
force-pushed
the
min-gdal-3-0
branch
2 times, most recently
from
7ae4df6 to
56e4a28
Compare
|
Added version info support to the README and a commit to drop the pre-built 2.4 bindings. Will wait a little before merging, since it's the kind of change that might make people upset. |
|
r? @metasim |
|
@lnicola What do you think about holding back this PR until after the 0.17 release? Since the pre-3.0 support works up to now, it would give legacy users one more release (with lots of improvements) to work with. |
|
FYI the |
|
Thanks for spotting that, updated in 0f2996a. |
|
@metasim there wasn't much negative feedback, do you think we could merge this? |
|
@lnicola Yes! Go for it! |
CHANGES.mdif knowledge of this change could be valuable to users.Closes #477
Closes #467