add raster mask methods #285
Conversation
|
Maybe we can create a separate Clippy PR based on parts of #284 |
|
yes we need to solve that issue anyway |
| pub struct GdalMaskFlags(i32); | ||
|
|
||
| impl GdalMaskFlags { | ||
| const GMF_ALL_VALID: i32 = 0x01; |
There was a problem hiding this comment.
I'm a bit surprised we don't have these in gdal-sys.
There was a problem hiding this comment.
i think it is a define not a const variable in the cpp code. I guess bindgen does not pick that up.
There was a problem hiding this comment.
Yeah, I'm not sure what's up, I think it should generate them.
There was a problem hiding this comment.
is bindgen able to handle defines? i can't find any examples.
There was a problem hiding this comment.
Yeah, it is: rust-lang/rust-bindgen#1185
There was a problem hiding this comment.
so what is wrong with our bindgen config? And i guess we would need to regenerate all bindings -_-
Co-authored-by: Laurențiu Nicola <lnicola@users.noreply.github.com>
|
@bors r+ |
|
bors r+ |
|
Build succeeded: |
CHANGES.mdif knowledge of this change could be valuable to users.