Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove datetime feature #229

Merged
merged 2 commits into from
Oct 19, 2021
Merged

Remove datetime feature #229

merged 2 commits into from
Oct 19, 2021

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Oct 19, 2021

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

Closes #169

@lnicola
Copy link
Member Author

lnicola commented Oct 19, 2021

I left in the feature for compatibility, but it does nothing. On the other hand, enabling it can break compatibility with downstream crates, as described in #169 (comment). So maybe I should remove it completely.

EDIT: I did that in a follow-up commit.

@lnicola
Copy link
Member Author

lnicola commented Oct 19, 2021

r? @jdroenner since this is in your L1 cache :-).

@jdroenner
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 19, 2021

@bors bors bot merged commit d930fbf into georust:master Oct 19, 2021
@lnicola lnicola deleted the datetime branch October 19, 2021 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: drop datetime feature (or drop FieldValue)
2 participants