Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Reader fixes #625

Merged
merged 174 commits into from
Mar 31, 2023
Merged

Bug: Reader fixes #625

merged 174 commits into from
Mar 31, 2023

Conversation

gaurav274
Copy link
Member

@gaurav274 gaurav274 commented Mar 30, 2023 •
edited
Loading

  1. Remove OpenCV based reader and fully move to decord - closing issue Frame Accurate Seeking #414
  2. Fix decord and csv reader test cases that weren't testing correctly.
  3. Fix bug with open UDF (imread Should Raise If Path Doesn't Exist opencv/opencv#14095)
  4. Remove timestamp UDF as we now support it using decord

aryan-rajoria and others added 30 commits February 9, 2023 19:21
@aryan-rajoria
adding delete operation
c9afc12
@aryan-rajoria
Adding Insert Statement
34dfbf7
@aryan-rajoria
checkpoint
9fa9857
@aryan-rajoria
supporting multiple entries
ebe26d3
@aryan-rajoria
implemented for structured data error
bc722dd
@aryan-rajoria
adding parser visitor for delete
0e29858
@aryan-rajoria
delete executor
c1a7864
@aryan-rajoria
delete plan and rules
5ac631a
@aryan-rajoria
adding delete to plan executor
3238e95
@aryan-rajoria
change position of LogicalDelete
02a1d28
@aryan-rajoria
logical delimeter
01181b5
@aryan-rajoria
delete test case
562a7ca
@aryan-rajoria
adding test case
9887732
@aryan-rajoria
adding test case
d2a1a3d
@aryan-rajoria
adding delete testcase
f09c613
@aryan-rajoria
adding predicate to delete executor
79a6168
@aryan-rajoria
adding delete to Image storage
5ce1991
@aryan-rajoria
bug fix in delete
91d7b06
@aryan-rajoria
fixing testcase
0aac934
@aryan-rajoria
adding test case for insert statement
ee48803
@aryan-rajoria
remove order_by from statement_binder.py
fc2f243
@aryan-rajoria
better variable names, using Batch
343a4a2
@aryan-rajoria
error message for insert
121451f
@aryan-rajoria
removing order_by and limit from delete
5b47c15
@aryan-rajoria
remove order_by and limit
8c75a5e
@aryan-rajoria
use f-string
6772cd0
@aryan-rajoria
adding to changelog
7a10d67
@aryan-rajoria
removing commit messages
1a4204f
@aryan-rajoria
formatting
e96d3a4
@aryan-rajoria
fixing comments
640e7ed
@gaurav274 gaurav274 changed the title Reader fixes Bug: Reader fixes Mar 30, 2023
@gaurav274 gaurav274 changed the base branch from master to fuzzy-join March 30, 2023 21:05
@gaurav274 gaurav274 changed the base branch from fuzzy-join to master March 30, 2023 21:05
@gaurav274 gaurav274 requested review from jarulraj and tushar-97 March 30, 2023 22:10
@gaurav274
Copy link
Member Author

@tushar-97 If this looks good, we can merge.

@gaurav274 gaurav274 merged commit 5c70a01 into master Mar 31, 2023
@gaurav274 gaurav274 deleted the reader-fixes branch March 31, 2023 03:38
@jarulraj jarulraj mentioned this pull request Apr 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tushar-97 tushar-97 tushar-97 approved these changes

@jarulraj jarulraj Awaiting requested review from jarulraj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaurav274 @tushar-97 @aryan-rajoria @jarulraj