feat: Add support for iframe based video sampling #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dungnmaster
force-pushed
the
iframe_sampling
branch
from
7ea6a76 to
029f34c
Compare
dungnmaster
changed the title
dungnmaster
force-pushed
the
iframe_sampling
branch
from
8b2b129 to
0f6d7c5
Compare
gaurav274
requested changes
Feb 23, 2023
eva/parser/eva.lark
Outdated
| @@ -122,6 +122,8 @@ subquery_table_source_item: (select_statement | LR_BRACKET select_statement RR_B | |||
|
|
|||
| sample_clause: SAMPLE decimal_literal | |||
|
|
|||
| sample_clause_with_type: SAMPLE decimal_literal string_literal | |||
There was a problem hiding this comment.
We should also support SAMPLE IFRAMES. I feel this is an important usecase
There was a problem hiding this comment.
default the sampling rate to 1
eva/readers/decord_reader.py
Outdated
| for frame_id in range(begin, end + 1, self._sampling_rate): | ||
| frame = video[frame_id] | ||
| if frame is not None: | ||
| yield {"id": frame_id, "data": frame} |
eva/readers/decord_reader.py
Outdated
| frame = video[frame_id] | ||
| idx += self._sampling_rate | ||
| if frame is not None: | ||
| yield {"id": frame_id, "data": frame} |
There was a problem hiding this comment.
Also add it in the opencv_reader
test/readers/test_decord_reader.py
Outdated
| ) | ||
| batches = list(video_loader.read()) | ||
| for batch in batches: | ||
| print(batch) |
test/readers/test_decord_reader.py
Outdated
| def tearDown(self): | ||
| file_remove("dummy.avi") | ||
|
|
||
| def test_should_sample_every_k_frame(self): |
There was a problem hiding this comment.
Also, add a test case for IFrames. Thanks!
eva/readers/decord_reader.py
Outdated
| can be converted to ranges. Defaults to None. | ||
| sampling_rate (int, optional): Set if the caller wants one frame | ||
| every `sampling_rate` number of frames. For example, if `sampling_rate = 10`, it returns every 10th frame. If both `predicate` and `sampling_rate` are specified, `sampling_rate` is given precedence. | ||
| sampling_type (str, optional): Set as 'iframe' if caller want to sample on top on iframes only. |
There was a problem hiding this comment.
Provide a few simple examples for explainability.
Rest looks good!
dungnmaster
force-pushed
the
iframe_sampling
branch
from
7c2685b to
bd140c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now videos can be sampled for IFRAMES using 'iframe' keyword with SAMPLE clause
e.g.
==> SELECT id FROM MyVideo SAMPLE IFRAMES 7 ORDER BY id;
==> SELECT id FROM MyVideo SAMPLE IFRAMES ; # this uses default sampling rate of 1