Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of query to check that trivial article matches survive #41

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

jmelot
Copy link
Contributor

@jmelot jmelot commented Apr 24, 2024

(It was timing out)

Also, handle article pairs we deliberately unlink.

…rvive.

Also, handle article pairs we deliberately unlink.
Copy link

No need for rebasing 👍
behind_count is 0
ahead_count is 1

Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
300 260 87% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: c43a0c7 by action🐍

@jmelot jmelot requested a review from katnquinn April 24, 2024 16:56
Copy link
Member

@katnquinn katnquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! I think the "where not in" can blow up which might be what was causing the issue?

@katnquinn katnquinn merged commit 97aa649 into master Apr 24, 2024
4 checks passed
@katnquinn katnquinn deleted the improve-match-check-performance branch April 24, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants