Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove georchestra analytics #295

Closed
wants to merge 1 commit into from
Closed

Remove georchestra analytics #295

wants to merge 1 commit into from

Conversation

edevosc2c
Copy link
Member

@edevosc2c edevosc2c commented Jul 15, 2024

Remove georchestra analytics since we can't use it because security proxy was removed.

Also remove security proxy file in envsubst.

This commit may be good to backport in georchestra/docker 24.0

@fvanderbiest
Copy link
Member

fvanderbiest commented Jul 15, 2024

This commit may be good to backport in georchestra/docker 24.0

Nope.
geOrchestra 24 is meant to be usable with both the security-proxy and the gateway.

But I see your point.
The docker composition has the gateway by default on branch 24.

Maybe commenting out analytics would be a better option in this branch.
In the same idea, having the security-proxy commented out would also make sense in the same branch.

@edevosc2c
Copy link
Member Author

Maybe commenting out analytics would be a better option in this branch.

Fine for me too.

In the same idea, having the security-proxy commented out would also make sense in the same branch.

Well security-proxy is gone from the docker composition: https://github.com/georchestra/docker/blob/24.0/docker-compose.yml and https://github.com/georchestra/docker/pull/197/files#diff-e45e45baeda1c1e73482975a664062aa56f20c03dd9d64a827aba57775bed0d3L82-L88

So I thought analytics wouldn't be necessary anymore too.

Maybe we need to bring back SP but commented? And comment analytics.

@jeanpommier
Copy link
Member

What about the header. Won't we have a broken entry (analytics) ?

@edevosc2c
Copy link
Member Author

Closing in favor of #305

@edevosc2c edevosc2c closed this Sep 27, 2024
@edevosc2c edevosc2c deleted the remove-analytics branch November 4, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants