Fix invalide use of encode on bytes object #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
cehbrecht
approved these changes
Mar 29, 2022
|
@gschwind Tests are all passing. Would you like to add a test to prove it is doing the right thing? |
1 similar comment
|
@gschwind Tests are all passing. Would you like to add a test to prove it is doing the right thing? |
|
I will have a look to add test, best regards |
gschwind
force-pushed
the
main-fix-request-storage
branch
from
b5d9dc3 to
ff8d3cc
Compare
|
I did a test but I'm not satisfied because the serialization-deserialition is not symmetric :) and the test is not symmetric too. |
Add test that check if binary data are correctly serialized to json in ComplexInput. The case append when json input are base64 encoded in the XML request.
Within the pywps.inout.inputs.ComplexInput the json convertion function use encode where decode should be used. The patch fix this issue.
gschwind
force-pushed
the
main-fix-request-storage
branch
from
ff8d3cc to
42b7508
Compare
|
I updated the test to only test the decoding, it should be fine now |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the pywps.inout.inputs.ComplexInput the json convertion function
use encode where decode should be used. The patch fix this issue.
same as #647 but main branch as base
Overview
Related Issue / Discussion
Additional Information
Contribution Agreement
(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)