Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kvp decoding to follow specification #597

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

gschwind
Copy link
Collaborator

Overview

In the specification of WPS 1.0.0 the specification state in section 10.2.2.1:

  1. All field values and attribute values shall be encoded using the standard Internet
    practice for encoding URLs [IETF RFC 1738].

Thus unquote values and attribute values as expected.

Related Issue / Discussion

Additional Information

Contribution Agreement

(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to PyWPS. I confirm that my contributions to PyWPS will be compatible with the PyWPS license guidelines at the time of contribution.
  • I have already previously agreed to the PyWPS Contributions and Licensing Guidelines

In the specification of WPS 1.0.0 the specification state in section 10.2.2.1:

6. All field values and attribute values shall be encoded using the standard Internet
practice for encoding URLs [IETF RFC 1738].

Thus unquote values and attribute values as expected.
@coveralls
Copy link

coveralls commented Apr 21, 2021

Coverage Status

Coverage remained the same at 0.0% when pulling 0823c32 on gschwind:pywps-4.4-001 into 5f486f1 on geopython:pywps-4.4.

@cehbrecht cehbrecht self-requested a review April 22, 2021 12:44
@cehbrecht cehbrecht merged commit cc07d71 into geopython:pywps-4.4 Apr 22, 2021
@gschwind gschwind deleted the pywps-4.4-001 branch April 25, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants