Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move MetadataUrl to pywps.app.Common to avoid dependencies on sphinx #565

Merged
merged 1 commit into from
Jan 25, 2021
Merged

move MetadataUrl to pywps.app.Common to avoid dependencies on sphinx #565

merged 1 commit into from
Jan 25, 2021

Conversation

tlvu
Copy link
Collaborator

@tlvu tlvu commented Jan 22, 2021 •
edited
Loading

Fixes #564

Tried the same steps as in the original issues, the error is gone.

$ python                                                                                                                                        
Python 3.8.5 (default, Sep  4 2020, 07:30:14)                                                                                                         
[GCC 7.3.0] :: Anaconda, Inc. on linux                                                                                                                
Type "help", "copyright", "credits" or "license" for more information.                                                                                
>>> from pywps import tests                                                                                                                           
>>>

Also tested this change in project using MetadataUrl at the old location:

cd <flyingpigeon checkout>
conda env update -f environment-docs.yml
conda activate flyingpigeon-docs
pip install git+https://github.com/geopython/pywps@fix-pywps.ext_autodoc.MetadataUrl-wrong-location --upgrade
make docs

Contribution Agreement

(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

  • [ x ] I'd like to contribute [feature X|bugfix Y|docs|something else] to PyWPS. I confirm that my contributions to PyWPS will be compatible with the PyWPS license guidelines at the time of contribution.
  • [x ] I have already previously agreed to the PyWPS Contributions and Licensing Guidelines

@tlvu
move MetadataUrl to pywps.app.Common to avoid dependencies on sphinx
d389ee6 
Steps to Reproduce
```bash
conda create -n pywps4.2.9 python=3.7
conda activate pywps4.2.9
python setup.py develop
python
```

Then
```python
from pywps import tests
Python 3.7.9 | packaged by conda-forge | (default, Dec  9 2020, 21:08:20)
[GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from pywps import tests
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/david/src/pywps/pywps/tests.py", line 15, in <module>
    from pywps.ext_autodoc import MetadataUrl
  File "/home/david/src/pywps/pywps/ext_autodoc.py", line 2, in <module>
    from sphinx.ext.autodoc import ClassDocumenter, bool_option
ModuleNotFoundError: No module named 'sphinx'
```
@tlvu tlvu requested a review from huard January 22, 2021 21:52
huard
huard approved these changes Jan 22, 2021
View reviewed changes
Copy link
Collaborator

@huard huard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
@cehbrecht Is it ok to push this in the 4.2 branch? I'm still confused regarding the status of master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 74.957% when pulling d389ee6 on fix-pywps.ext_autodoc.MetadataUrl-wrong-location into effc9cd on pywps-4.2.

@tlvu tlvu mentioned this pull request Jan 22, 2021
Merged
@tlvu tlvu linked an issue Jan 23, 2021 that may be closed by this pull request
Missing dependency in 4.2.9 #564
Closed
@cehbrecht cehbrecht self-requested a review January 25, 2021 10:49
@cehbrecht
Copy link
Collaborator

Looks good.
@cehbrecht Is it ok to push this in the 4.2 branch? I'm still confused regarding the status of master.

Yes ... the 4.2 branch is still our production version.

@cehbrecht cehbrecht merged commit 0c18a2e into pywps-4.2 Jan 25, 2021
@cehbrecht cehbrecht mentioned this pull request Jan 25, 2021
Closed
@cehbrecht
Copy link
Collaborator

@tlvu @huard Thanks for the fix 😄

@tlvu tlvu deleted the fix-pywps.ext_autodoc.MetadataUrl-wrong-location branch January 25, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cehbrecht cehbrecht cehbrecht approved these changes

@huard huard huard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing dependency in 4.2.9
4 participants
@tlvu @coveralls @cehbrecht @huard