Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bbox in execute template #552

Merged
merged 2 commits into from
Dec 3, 2020
Merged

fix bbox in execute template #552

merged 2 commits into from
Dec 3, 2020

Conversation

cehbrecht
Copy link
Collaborator

Overview

According to the wps 1.0.0 schema the bbox in the execute response should look like this:

<wps:BoundingBoxData crs="epsg:4326" dimensions="2">
          <ows:LowerCorner> -90.0 -180.0</ows:LowerCorner>
           <ows:UpperCorner> 90.0 180.0</ows:UpperCorner>
</wps:BoundingBoxData>

The schema has no entry for WGS84BoundingBox.

Related Issue / Discussion

Additional Information

Contribution Agreement

(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to PyWPS. I confirm that my contributions to PyWPS will be compatible with the PyWPS license guidelines at the time of contribution.
  • [x ] I have already previously agreed to the PyWPS Contributions and Licensing Guidelines

@cehbrecht cehbrecht added the bug label Dec 2, 2020
@cehbrecht cehbrecht added this to the 4.4.0 milestone Dec 2, 2020
@cehbrecht cehbrecht self-assigned this Dec 2, 2020
@cehbrecht cehbrecht marked this pull request as draft December 2, 2020 17:48
@cehbrecht cehbrecht marked this pull request as ready for review December 2, 2020 18:17
@cehbrecht
Copy link
Collaborator Author

WPS Execute outputs are:

<element name="Output" type="wps:OutputDataType" maxOccurs="unbounded">

https://github.com/opengeospatial/ets-wps10/blob/884f69b9bef900f832bd3ffaead5e99aab972032/src/main/resources/xsd/ogc/wps/1.0.0/wpsExecute_response.xsd#L58

These can be Data:

<element name="Data" type="wps:DataType">

And this can be a bbox:

<element name="BoundingBoxData" type="ows:BoundingBoxType">

https://github.com/opengeospatial/ets-wps10/blob/884f69b9bef900f832bd3ffaead5e99aab972032/src/main/resources/xsd/ogc/wps/1.0.0/wpsExecute_request.xsd#L240

ows:BoundingBoxType with lower and upper corner:
https://github.com/opengeospatial/ets-wps10/blob/884f69b9bef900f832bd3ffaead5e99aab972032/src/main/resources/xsd/ogc/ows/1.1.0/owsCommon.xsd#L67

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.442% when pulling 13e540f on cehbrecht:fix-bbox-response into 83c3680 on geopython:pywps-4.2.

@cehbrecht cehbrecht merged commit 9fa56cc into geopython:pywps-4.2 Dec 3, 2020
@cehbrecht cehbrecht deleted the fix-bbox-response branch December 3, 2020 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants